Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kirby and Brave #29

Open
austintgriffith opened this issue Sep 20, 2019 · 2 comments
Open

Kirby and Brave #29

austintgriffith opened this issue Sep 20, 2019 · 2 comments

Comments

@austintgriffith
Copy link
Contributor

I'm getting some feedback that https://signator.io doesn't work in Brave.

I can replicate the issue:
image

The user may have to manually changes some settings in Brave for Kirby to work 馃様
@austintgriffith
Copy link
Contributor Author

image

@dankins dankins mentioned this issue Sep 20, 2019
Merged
@dankins
Copy link
Owner

dankins commented Sep 20, 2019 •
edited

Tried to solve it by storing PK in a cookie instead of localStorage with this PR: #30
However, it still seems to be trying to access localStorage and blowing up on this line:
https://github.com/ethereum/web3.js/blob/1.x/packages/web3-eth-accounts/src/index.js#L515

As far as I can tell this PR tries to fix it:
web3/web3.js#3031
but I don't think it is in a release yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dankins @austintgriffith