Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red-green colorblind accessibility issue with coverage report #595

Closed
kristinnbragi opened this issue Mar 3, 2023 · 9 comments
Closed

Comments

@kristinnbragi
Copy link

kristinnbragi commented Mar 3, 2023

I was going over code coverage results with a developer who has colour blindness and discovered that the tool is not accessible for red green colour blindness. Line highlights are especially hard to differentiate due to the desaturated colour. A natural fix would be to include symbols as a supplement.
Screenshot 2023-03-03 at 14 50 02

@danielpalme
Copy link
Owner

I totally understand that this is an issue.

  • Do you have a concrete idea for "include symbols as a supplement"?
  • Would a different color scheme be more helpful (e.g. blue/yellow instead of green/red). What would be good colors?

@kristinnbragi
Copy link
Author

kristinnbragi commented Mar 6, 2023

Do you have a concrete idea for "include symbols as a supplement"?

Not really, although a simple + or - would work, it might also be misleading. Another tool, Bullseye, uses these icons for example:
Screenshot 2023-03-06 at 15 48 43

Would a different color scheme be more helpful (e.g. blue/yellow instead of green/red). What would be good colors?

Definitely! I don't know what colors would make sense that would support all types of color blindness. Ultimately, the best solution would be to offer the user to choose their own color scheme

danielpalme added a commit that referenced this issue Mar 9, 2023
@danielpalme
Copy link
Owner

I added a new report type Html_BlueRed in version 5.1.19
To use it, add the following command line parameter when executing ReportGenerator: -reporttypes:Html_BlueRed

Here you can find a sample report:
https://reportgenerator.io/resources/reports/Html_BlueRed/index.html

Hope this helps!

@vzhik54
Copy link

vzhik54 commented Sep 25, 2023

I added a new report type Html_BlueRed in version 5.1.19 To use it, add the following command line parameter when executing ReportGenerator: -reporttypes:Html_BlueRed

Here you can find a sample report: https://reportgenerator.io/resources/reports/Html_BlueRed/index.html

Hope this helps!

Hello.
Could you please clarify what type of reports I can use for summary report to resolve the same trouble?

@danielpalme
Copy link
Owner

Hello. Could you please clarify what type of reports I can use for summary report to resolve the same trouble?

There no separate Blue_Red summary report yet.
But I can add this in the next release.

@vzhik54
Copy link

vzhik54 commented Sep 27, 2023

Thanks a lot

danielpalme added a commit that referenced this issue Sep 29, 2023
@danielpalme
Copy link
Owner

@vzhik54
I just created a sample report: https://reportgenerator.io/resources/reports/Html_BlueRed_Summary/summary.html

Does this work for you?

The next release will contain the new report type Html_BlueRed_Summary.

@vzhik54
Copy link

vzhik54 commented Sep 30, 2023

@danielpalme
Yes, this report type work for me. Thanks :-)

@danielpalme
Copy link
Owner

Release 5.1.26 is now available. It contains the new report type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants