Fix regex to exclude Wikipedia links to image file pages #156
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex to exclude the Wikipedia links does not always work as if you visit a page in a different language, i.e. Danish, the link will look differently:
https://da.m.wikipedia.org/wiki/Fil:Danmark-locator.png
This will break the images when using the --inline cli option as it will instead try to base64 encode contents of
https://da.m.wikipedia.org/wiki/Fil:Danmark-locator.png
, which is an HTML page.I propose that we change the regex as shown in the commit to take into account different languages.