Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove allowed_failure from Python 3.12 #5815

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

da-woods
Copy link
Contributor

and disable profiling tests there, since it doesn't look like we'll be able to fix them.

Knowing about other regressions is probably more important than testing profiling...

and disable profiling tests there, since it doesn't look like
we'll be able to fix them.

Knowing about other regressions is probably more important than
testing profiling...
@da-woods da-woods added this to the 3.0.6 milestone Nov 14, 2023
@da-woods da-woods merged commit 857736e into cython:master Nov 14, 2023
63 of 64 checks passed
da-woods added a commit that referenced this pull request Nov 14, 2023
and disable profiling tests there, since it doesn't look like
we'll be able to fix them.

Knowing about other regressions is probably more important than
testing profiling...
@da-woods da-woods deleted the turn-off-profiling-312 branch November 14, 2023 18:40
@da-woods
Copy link
Contributor Author

In 3.0.x in f71205d

@scoder
Copy link
Contributor

scoder commented Nov 14, 2023 via email

@da-woods
Copy link
Contributor Author

Looks like we used the "in" operator just above to disable tests. Seems simpler than something as obscure as "find() != - 1"

I've gone back and fixed that.

@da-woods
Copy link
Contributor Author

I missed that there's a Windows Py3.12 failure. I'll have a look at that this evening. Possibly by just turning Windows 3.12 to an allowed failure for now.

@mattip
Copy link
Contributor

mattip commented Nov 15, 2023

It seems master is failing in more than just windows. The master run (after the merge of #5819) seems to be failing on python3.13, ubuntu-20.04, pypy-3.9-v7.3.12, the latter with a failure in trashcan.Sub2

@da-woods
Copy link
Contributor Author

#5826 is the fixup for CyCache on Windows.

@mattip - I think that trashcan test may be "flakey" in PyPy rather a permanent failure (which I suspect we can live with) - it seems OK on other recent runs. That probably makes sense - it's looks like something that might work best with deterministic destructors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants