Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable video collection and artifact upload for v12 examples #932

Merged
merged 1 commit into from Jun 5, 2023

Conversation

MikeMcC399
Copy link
Collaborator

This PR makes changes affecting Chrome and Edge browser testing for Cypress 12.x based tests: It ...

(examples/v9 are not changed)

Reasons

Harmonization, simplification and preparation for future Cypress release:

  1. Groundwork to be able to consolidate and harmonize browser testing:
  2. Uploading video artifacts in addition to screenshot artifacts is not necessary in order to demonstrate artifact upload. Screenshot upload is sufficient for that purpose.
  3. Prepares examples for planned changes in Cypress 13 (see Turn off video recording by default cypress#26157). The v10+ examples for Chrome, Edge and Firefox continue to be compatible with Cypress 10 - 12 and should also be compatible with Cypress 13 when it is released.

Proposed follow-on steps

In a follow-on PR, additional changes could then be made:

  1. Change .github/workflows/example-firefox.yml to use common examples/browser working-directory
  2. Remove examples/firefox redundant working-directory

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review June 5, 2023 08:15
@AtofStryker AtofStryker merged commit 61a130a into cypress-io:master Jun 5, 2023
117 checks passed
@MikeMcC399 MikeMcC399 deleted the disable-video-collection branch June 5, 2023 16:18
@github-actions
Copy link

🎉 This PR is included in version 5.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants