Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix version update for yarn workspace #1069

Merged

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Oct 25, 2023

Issue

If scripts/update-cypress-latest-other.sh is run on a cleanly cloned repository or on one where git clean has been run, then it fails to update Cypress in the Yarn workspace-2 examples/start-and-yarn-workspaces/workspace-2. If it is run again, then the update works as expected.

Change

Replace the use of npm install in scripts/update-cypress-latest-other.sh operating on examples/start-and-yarn-workspaces by yarn workspace commands to update Cypress to the latest version.

Verification

In clone of https://github.com/cypress-io/github-action

git clean -x -f -d
npm ci
npm install yarn@latest -g
npm install pnpm@latest -g
./scripts/update-cypress-latest-other.sh

Ensure there are no errors reported.

Compare the version of Cypress installed in examples/start-and-yarn-workspaces

cd examples/start-and-yarn-workspaces
yarn list --pattern cypress

with the latest version shown by

npm view cypress dist-tags

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review October 25, 2023 15:00
@MikeMcC399 MikeMcC399 force-pushed the build/fix-yarn-workspace-update branch from 108d74d to 862d164 Compare October 27, 2023 07:10
@emilyrohrbough
Copy link
Member

Thank you @MikeMcC399

@emilyrohrbough emilyrohrbough merged commit ba1e951 into cypress-io:master Oct 31, 2023
71 checks passed
@MikeMcC399 MikeMcC399 deleted the build/fix-yarn-workspace-update branch October 31, 2023 17:58
Copy link

🎉 This PR is included in version 6.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants