Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): downgrade to qs@6.10.4 in yarn-classic example #1064

Merged
merged 1 commit into from Oct 23, 2023

Conversation

MikeMcC399
Copy link
Collaborator

Issue

examples/yarn-classic through

qs@~6.10.3:
version "6.10.5"
resolved "https://registry.yarnpkg.com/qs/-/qs-6.10.5.tgz#974715920a80ff6a262264acd2c7e6c2a53282b4"
integrity sha512-O5RlPh0VFtR78y79rgcgKK4wbAI0C5zGVLztOIdpWX6ep368q5Hv6XRxDvXuZ9q3C6v+e3n8UfZZJw7IIG27eQ==
dependencies:
side-channel "^1.0.4"

continues to use the deprecated qs@6.10.5.

Yarn Classic does not avoid deprecated versions, unlike Yarn Modern.

$ cd examples/yarn-classic
$ yarn list --pattern qs
yarn list v1.22.19
└─ qs@6.10.5

Change

cypress is removed and reinstalled to allow Yarn to pick up @cypress/request@3.0.1 which is pegged to the required (non-deprecated) qs@6.10.4.

Further Suggestion

A future version of Cypress could be updated to depend on @cypress/request@^3.0.1 instead of on @cypress/request@^3.0.0 to avoid this mismatch in Yarn Classic installations.

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review October 23, 2023 12:37
@mschile mschile merged commit 58f8597 into cypress-io:master Oct 23, 2023
71 checks passed
@MikeMcC399 MikeMcC399 deleted the update/yarn-classic-qs branch October 24, 2023 05:12
Copy link

🎉 This PR is included in version 6.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants