Some asynchronously thrown spec errors do not fail test

[flotwig]

Current behavior

Uncaught rejections thrown in tests that use done will not fail the test when no cy chain is active:

cypress/packages/server/test/support/fixtures/projects/e2e/cypress/integration/caught_async_sync_test_spec.coffee

Lines 89 to 95 in f65fd61

	# bad
	it "quux8 fails", (done) ->
	Cypress.Promise.resolve()
	.then ->
	foo.bar()
	return

Similar behavior exists for other unhandled rejections:

cypress/packages/server/test/support/fixtures/projects/e2e/cypress/integration/caught_async_sync_test_spec.coffee

Lines 70 to 73 in f65fd61

	# bad, doesn't log to console, unlike Promiser unhandled rejections
	it "quux7d fails", (done) ->
	window.top.setImmediate ->
	foo.bar()

Potentially related: some asynchronous test failures are incorrectly attributed to the AUT, not the spec window.

Desired behavior

Correctly attribute unhandled rejections and exceptions to the spec or the AUT, do not miss handling any errors.

Test code to reproduce

See #8221

[flotwig]

This affects cy.route2 req/res callbacks pretty hard - failing assertions in those callbacks will display in the command log, but will not cause the test to be failed.

[Andarist]

Wouldnt this be just a matter of binding correctly unhandledrejection listener in those places:

cypress/packages/driver/src/cy/listeners.js

Lines 52 to 53 in 9ccc7a6

	// set onerror global handler
	contentWindow.onerror = callbacks.onError

cypress/packages/driver/src/cypress/runner.js

Line 923 in 3e52df0

specWindow.onerror = function () {

cypress/packages/driver/src/cypress/cy.js

Line 95 in 052892d

top.onerror = onTopError

If that's the answer then I could work on fixing this.

[github-actions]

Internal Jira issue: TR-670

[cypress-bot]

The code for this is done in cypress-io/cypress#14826, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

Released in 7.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.0.0, please open a new issue.