From bc0ca8322f9161c18317ab3dabc4da3f2138f47e Mon Sep 17 00:00:00 2001 From: Ryan Manuel Date: Wed, 30 Aug 2023 11:47:21 -0500 Subject: [PATCH 1/4] Update protocol.ts --- packages/server/lib/cloud/protocol.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/server/lib/cloud/protocol.ts b/packages/server/lib/cloud/protocol.ts index adec482ede01..5f3d851fd193 100644 --- a/packages/server/lib/cloud/protocol.ts +++ b/packages/server/lib/cloud/protocol.ts @@ -112,7 +112,7 @@ export class ProtocolManager implements ProtocolManagerShape { await listener(message) } catch (error) { if (CAPTURE_ERRORS) { - this._errors.push({ captureMethod: 'cdpClient.on', fatal: true, error, args: [event, message] }) + this._errors.push({ captureMethod: 'cdpClient.on', fatal: false, error, args: [event, message] }) } else { debug('error in cdpClient.on %O', { error, event, message }) throw error From 78949c7538422f9708e65f378765c6c22498c559 Mon Sep 17 00:00:00 2001 From: Ryan Manuel Date: Wed, 30 Aug 2023 11:55:15 -0500 Subject: [PATCH 2/4] Update CHANGELOG.md --- cli/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/cli/CHANGELOG.md b/cli/CHANGELOG.md index a583918ebd33..ce25595a56d1 100644 --- a/cli/CHANGELOG.md +++ b/cli/CHANGELOG.md @@ -7,6 +7,10 @@ _Released 09/12/2023 (PENDING)_ - Introduce a status icon representing the `latest` test run in the Sidebar for the Runs Page. Addresses [#27206](https://github.com/cypress-io/cypress/issues/27206). +**Bugfixes:** + +- Individual CDP errors that occur while capturing data for test replay will no longer prevent the entire run from being available. Addressed in [#27709](https://github.com/cypress-io/cypress/pull/27709). + ## 13.0.0 _Released 08/29/2023_ From 0bca3c1efa13a086de0c213239e552d013bcbc31 Mon Sep 17 00:00:00 2001 From: Ryan Manuel Date: Wed, 30 Aug 2023 12:33:55 -0500 Subject: [PATCH 3/4] Update protocol.ts --- packages/server/lib/cloud/protocol.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/server/lib/cloud/protocol.ts b/packages/server/lib/cloud/protocol.ts index 5f3d851fd193..1fdcad53290a 100644 --- a/packages/server/lib/cloud/protocol.ts +++ b/packages/server/lib/cloud/protocol.ts @@ -137,6 +137,9 @@ export class ProtocolManager implements ProtocolManagerShape { try { this._beforeSpec(spec) } catch (error) { + // Clear out protocol since we will not have a valid state when spec has failed + this._protocol = undefined + if (CAPTURE_ERRORS) { this._errors.push({ captureMethod: 'beforeSpec', error, args: [spec], runnableId: this._runnableId }) } else { From 53278cfd68b970b59ad5f0f9745ea2c9110d32ae Mon Sep 17 00:00:00 2001 From: Ryan Manuel Date: Wed, 30 Aug 2023 13:37:19 -0500 Subject: [PATCH 4/4] Update packages/server/lib/cloud/protocol.ts --- packages/server/lib/cloud/protocol.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/server/lib/cloud/protocol.ts b/packages/server/lib/cloud/protocol.ts index 1fdcad53290a..98163018db0d 100644 --- a/packages/server/lib/cloud/protocol.ts +++ b/packages/server/lib/cloud/protocol.ts @@ -141,7 +141,7 @@ export class ProtocolManager implements ProtocolManagerShape { this._protocol = undefined if (CAPTURE_ERRORS) { - this._errors.push({ captureMethod: 'beforeSpec', error, args: [spec], runnableId: this._runnableId }) + this._errors.push({ captureMethod: 'beforeSpec', fatal: true, error, args: [spec], runnableId: this._runnableId }) } else { throw error }