Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Understand/fix any implications of unload event deprecation within Chrome #29241

Closed
jennifer-shehane opened this issue Apr 1, 2024 · 2 comments · Fixed by #29525
Closed

Understand/fix any implications of unload event deprecation within Chrome #29241

jennifer-shehane opened this issue Apr 1, 2024 · 2 comments · Fixed by #29525
Assignees
@cacieprins
Labels
browser: chromium

Comments

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Apr 1, 2024 •
edited

What would you like?

https://developer.chrome.com/docs/web-platform/deprecating-unload

Chrome is deprecating the upload event where it will begin ceasing to functions for some websites starting Q3 2024.

We should enable the flags to turn it off to understand the implications of the deprecation. https://github.com/fergald/docs/blob/master/explainers/permissions-policy-deprecate-unload.md#testing-with-chrome

We'll also need to handle users that have this flag manually turned on past the deprecation.

I opened a PR to deprecate the unload event to see what would fail here: #29242

Why is this needed?

No response

Other

No response
@jennifer-shehane jennifer-shehane added browser: chromium stage: needs investigating Someone from Cypress needs to look at this labels Apr 1, 2024
@jennifer-shehane jennifer-shehane changed the title Understand implications of unload event deprecation within Chrome Understand/fix any implications of unload event deprecation within Chrome Apr 1, 2024
@jennifer-shehane jennifer-shehane added stage: investigating Someone from Cypress is looking into this and removed stage: needs investigating Someone from Cypress needs to look at this labels May 3, 2024
@cacieprins cacieprins mentioned this issue May 6, 2024
Closed
@cacieprins
Copy link
Contributor

Next step: Determine if pagehide event will suffice for a replacement event

@cacieprins cacieprins mentioned this issue May 15, 2024
Merged
1 task
@jennifer-shehane jennifer-shehane mentioned this issue May 22, 2024
Closed
@jennifer-shehane jennifer-shehane removed the stage: investigating Someone from Cypress is looking into this label Jun 3, 2024
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 4, 2024

Released in 13.11.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.11.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cacieprins cacieprins

Labels
browser: chromium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: preserve navigation functionality when unload event is deprecated cypress-io/cypress
2 participants
@cacieprins @jennifer-shehane