Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate window:unload #29524

Open
cacieprins opened this issue May 15, 2024 · 0 comments
Open

Deprecate window:unload #29524

cacieprins opened this issue May 15, 2024 · 0 comments
Labels
browser: chrome type: enhancement Requested enhancement of existing feature

Comments

@cacieprins
Copy link
Contributor

cacieprins commented May 15, 2024

What would you like?

I would like to be warned, either on stdout or in the command log, when I add listeners to the window:unload Cypress event.

Why is this needed?

The window unload event is being removed from Chrome. As a stopgap, Cypress is emitting window:unload when pagehide is emitted: #29525. To keep Cypress' API aligned with the w3 spec, we should be emitting a window:pagehide event instead. To notify users that this event is being deprecated in a future major version of Cypress, we should include warnings in the command log and/or stdout.

Other

No response

@jennifer-shehane jennifer-shehane added the type: enhancement Requested enhancement of existing feature label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser: chrome type: enhancement Requested enhancement of existing feature
Projects
None yet
Development

No branches or pull requests

2 participants