chore: right size some circleci jobs #29448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 flaky test on run #55311 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > past Max-Age, before Expires -> not logged in |
Review all test suite changes for PR #29448 ↗︎ | |
mschile
approved these changes
May 2, 2024
ryanthemanuel
approved these changes
May 6, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Updating our Circle job resources to be better right sized. Some were using 100% resources, so those have been bumped up. Some were not using near 100% resources, so those have been bumped down.
The timing of the run is the same as before, but I would expect to have less situations of flake that would be caused by a situation where resources are strained.
Increasing resource sizes does increase cost.
How has the user experience changed?
N/A, but for internal:
Before
After
Before
After
PR Tasks
cypress-documentation?type definitions?