Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add experimentalMemoryManagement flag to our cy-in-cy App tests #29359

Merged
merged 7 commits into from Apr 22, 2024

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Apr 18, 2024

Close #29357

Additional details

This PR sets experimentalMemoryManagement to true for our internal app tests. Our internal App tests run cypress within cypress, which is a unique situation that our users don't encounter. The memory used in Chrome was causing this job to crash Chrome frequently.

I don't see a large increase in the time to run these tests, maybe an increase of ~20-30 secs in linux and windows. I suspect they'll be more stable though.

Additionally, this PR upgrades the resource class used to run run-app-integration-tests-chrome job to large from medium. The medium resource class was always maxing out at 100% CPU.

Before

https://app.circleci.com/pipelines/github/cypress-io/cypress/61043/workflows/b0bfd961-3476-4450-9916-36d299560584/jobs/2538781/resources

Screenshot 2024-04-19 at 9 52 18 AM

After

https://app.circleci.com/pipelines/github/cypress-io/cypress/61054/workflows/fe25bb31-be6e-46b8-95ce-3bd72d1ea068/jobs/2538662/resources

Screenshot 2024-04-19 at 9 52 09 AM

Steps to test

Tests should pass. I also ran this on Windows jobs.

How has the user experience changed?

PR Tasks

Copy link

cypress bot commented Apr 18, 2024

2 failed and 4 flaky tests on run #55073 ↗︎

2 225 4 0 Flakiness 4

Details:

removed debug logs in windows
Project: cypress Commit: 70fe6133e8
Status: Failed Duration: 14:32 💡
Started: Apr 22, 2024 5:12 PM Ended: Apr 22, 2024 5:26 PM
Failed  cypress\e2e\project-setup.cy.ts • 2 failed tests • launchpad-e2e

View Output

Test Artifacts
... > skips the setup page when choosing e2e tests to run Test Replay Screenshots
Launchpad: Setup Project > openLink > opens docs link in the default browser Test Replay Screenshots
Flakiness  cypress\e2e\project-setup.cy.ts • 3 flaky tests • launchpad-e2e

View Output

Test Artifacts
... > shows the configuration setup page when selecting e2e tests Test Replay Screenshots
... > can skip setup CT testing for an E2E project Test Replay Screenshots
Launchpad: Setup Project > switch testing types > takes the user to first step of e2e setup when switching from app Test Replay Screenshots
Flakiness  cypress\e2e\scaffold-component-testing.cy.ts • 1 flaky test • launchpad-e2e

View Output

Test Artifacts
scaffolding component testing > angular-cli-unconfigured > scaffolds component testing for Angular Test Replay Screenshots

Review all test suite changes for PR #29359 ↗︎

@jennifer-shehane jennifer-shehane self-assigned this Apr 19, 2024
Comment on lines -675 to -677
if [[ <<parameters.package>> == 'app' && <<parameters.type>> == 'e2e' ]]; then
export DEBUG=cypress:*
fi
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed these DEBUG flag from windows because I couldn't see if the errors were legitimate or not with the debug on (they were not)

@jennifer-shehane
Copy link
Member Author

@jennifer-shehane jennifer-shehane merged commit 734968a into develop Apr 22, 2024
123 of 128 checks passed
@jennifer-shehane jennifer-shehane deleted the app-mem-mng-flag branch April 22, 2024 17:55
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 23, 2024

Released in 13.8.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.8.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: Chrome renderer crash on reporter.command_errors.cy.ts
3 participants