fix: websocket closed (tentative) #29347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted errors as websocket in closing/closed state errors
Passing run #55090 ↗︎
Details:
Review all test suite changes for PR #29347 ↗︎ |
|||||||||||||||
cacieprins
force-pushed
the
cacie/fix/websocket-closed
branch
from
5a3e768
to
59a1198
Compare
AtofStryker
approved these changes
Apr 22, 2024
Co-authored-by: Bill Glesias <bglesias@gmail.com>
|
|
||
| const WEBSOCKET_NOT_OPEN_RE = /^WebSocket is (?:not open|already in CLOSING or CLOSED state)/ | ||
| const WEBSOCKET_NOT_OPEN_RE = /^WebSocket (?:connection closed|is (?:not open|already in CLOSING or CLOSED state))/ |
There was a problem hiding this comment.
Can we document what the various messages are that we're covering here? I always like to have examples around regexes for my future self.
There was a problem hiding this comment.
Addressed in a613bca
ryanthemanuel
approved these changes
Apr 22, 2024
ryanthemanuel
approved these changes
Apr 22, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This is a tentative fix. This issue has been very difficult if not impossible to reproduce, and this is my best guess solution.
Occasionally, certain systems can send CDP commands that will fail due to the CRI websocket being closed with those commands mid-flight. This is most common with video recording ACK commands, but can potentially occur with any automation command. Prior to
chrome-remote-interface@0.33.0, it seems as though these commands failed silently.0.33.0introduced behavior where it will throw an error in this situation. This exception was uncaught, causing Cypress to intermittently exit with code 1 even thought a given spec had succeeded.This PR:
Error: WebSocket connection closederrors similarly toWebSocket is not openandWebSocket already in CLOSING or CLOSED stateerrors: the command is enqueued, and reconnection to the CRI websocket is attemptedRuntime.addBinding,DOM.enable) from the command queue, if present, when sending them upon reconnection. This prevents them from being re-sent when iterating through the queued commands.Steps to test
Run server unit and integration tests. A reproduction of the original issue is unavailable, and confirmation on a fix will be pending user feedback.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?