misc: suppress benign vulkan warnings #29278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacieprins
changed the title
MikeMcC399
reviewed
Apr 5, 2024
cli/CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ _Released 4/16/2024 (PENDING)_ | |||
| **Misc:** | |||
|
|
|||
| - Updated the Chrome flags to not show the "Enhanced Ad Privacy" dialog. Addresses [#29199](https://github.com/cypress-io/cypress/issues/29199). | |||
| - Suppresses benign warnings that reference Vulkan on GPU-less Docker hosts. Addresses [#29085](https://github.com/cypress-io/cypress/issues/29085). Addressed in [#29278](https://github.com/cypress-io/cypress/pull/29278). | |||
There was a problem hiding this comment.
The issue affects environments without Docker, so you could probably just say
"on GPU-less hosts."
and leave out the word "Docker".
There was a problem hiding this comment.
Thank you! Addressed in 48b406d
4 flaky tests on run #54867 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > passes through assertion error when not about existence |
Test Replay
|
|
waiting.cy.js • 2 flaky tests • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws whenever an alias times out |
Test Replay
|
|
| ... > errors > throws when waiting for 2nd response to route |
Test Replay
|
|
waiting.cy.js • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when waiting for 2nd response to route |
Test Replay
|
|
Review all test suite changes for PR #29278 ↗︎
jennifer-shehane
approved these changes
Apr 10, 2024
AtofStryker
requested review from
AtofStryker
and removed request for
MikeMcC399
emilyrohrbough
approved these changes
Apr 10, 2024
AtofStryker
approved these changes
Apr 10, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
The primary Cypress process can emit benign warnings about Vulkan when run on a machine that does not have a GPU, or a docker container whose host does not have a GPU. Vulkan is a cross-platform API for 3D rendering, and is not necessary for the primary Cypress process to execute correctly. This warning is not emitted from the web browser that Cypress launches, and should not be impacting the success of tests. This PR suppresses the warning from stdout, similar to other benign Electron warnings.
Steps to test
How has the user experience changed?
Users will no longer see benign Electron warnings about Vulkan on machines and docker containers that do not have access to a GPU.
PR Tasks
cypress-documentation?type definitions?