docs: correct link from examples readme to pr contributing #29163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This comment was marked as outdated.
This comment was marked as outdated.
jennifer-shehane
approved these changes
Mar 18, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
In packages/example/README.md the instruction
3. Create a new pull-request following this repo's [pull request instructions](CONTRIBUTING.md#pull-requests).links to a non-existent file, producing a
404error.This PR changes the link to point to https://github.com/cypress-io/cypress/blob/develop/CONTRIBUTING.md#pull-requests instead.
Steps to test
Open README and click on link to pull request instructions. Confirm that corresponding content is displayed.
How has the user experience changed?
See above.
PR Tasks
cypress-documentation?type definitions?