chore: skip flaky tests #29149
Merged
chore: skip flaky tests #29149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifer-shehane
added
the
process: flaky test
jennifer-shehane
changed the title
mschile
approved these changes
Mar 14, 2024
cacieprins
approved these changes
Mar 14, 2024
3 flaky tests on run #54547 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > throws when alias property isnt just a digit |
Test Replay
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when waiting for 2nd response to route |
Test Replay
|
|
e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > throws when foo cannot resolve |
Test Replay
|
|
Review all test suite changes for PR #29149 ↗︎
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
1. First Flaky Test
Test Replay
This test is our flakiest test right now. I've looked into it, and I can't figure out why it's flaking, maybe it's a slight timing difference and could be a bug in how we're rendering. What's happening:
In this case where there are no runs recorded, the view renders this loading styles instead of the --- placeholder text. Since this is very low impact even if this is a bug, I think we should just skip this test and save ourselves the time of rerunning our whole suite when this fails.
Passing
Failing
2. Second flaky test
This test only seems to be flaky when run in Webkit, so I think we should skip webkit. There are some other tests in that file that are not run in webkit.
How has the user experience changed?
N/A
PR Tasks
N/A