fix: launch args with multiple values inside quotes #29077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
chore: Update Chrome (beta) to 123.0.6312.28 (cypress-io#29080)
AtofStryker
requested changes
Mar 19, 2024
There was a problem hiding this comment.
Hi @erwin-huang. Thank you for opening a PR! The changes for the most part look good on my end. Just a few comments/suggestions.
|
@erwin-huang Will you be able to address the review comments for this PR? We'll have to close the PR if not. |
Co-authored-by: Bill Glesias <bglesias@gmail.com>
Hi @jennifer-shehane, thanks for letting me know, I've updated the PR. |
AtofStryker
reviewed
Apr 3, 2024
Co-authored-by: Bill Glesias <bglesias@gmail.com>
AtofStryker
approved these changes
Apr 5, 2024
cacieprins
approved these changes
Apr 9, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed launch electron args with multiple values inside quotes.
Example
--foo=--bar=4196--foo='--bar=4196 --baz=quux'or--foo="--bar=4196 --baz=quux"Closes #27454
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?