Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Delete gitignore for server #28977

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

jennifer-shehane
Copy link
Member

Additional details

Revert change made in https://github.com/cypress-io/cypress/pull/27848/files#diff-ac6c6375f4f1da4088831e74ffba8c895a2d5b8940d64aa4dbe345b0df9f19a3 that will ignore all JS files within the server package in git.

Steps to test

Tests pass

How has the user experience changed?

It shouldn't change. I have no idea if some changes were attempted to be made to these files that wasn't commited. We'll have to assume not.

PR Tasks

@jennifer-shehane jennifer-shehane self-assigned this Feb 20, 2024
Copy link

cypress bot commented Feb 20, 2024

9 flaky tests on run #54107 ↗︎

0 28947 1341 0 Flakiness 9

Details:

empty commit
Project: cypress Commit: dae2bd9954
Status: Passed Duration: 20:40 💡
Started: Feb 20, 2024 10:05 PM Ended: Feb 20, 2024 10:26 PM
Flakiness  commands/files.cy.js • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > throws a specific error when file exists when it shouldn't Test Replay
Flakiness  project-setup.cy.ts • 1 flaky test • launchpad-e2e

View Output

Test Artifacts
Launchpad: Setup Project > switch testing types > takes the user to first step of e2e setup when switching from app Test Replay Screenshots
Flakiness  config-warning.cy.ts • 1 flaky test • launchpad-e2e

View Output

Test Artifacts
experimentalStudio > is a valid config for e2e testing Test Replay Screenshots
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Screenshots
Flakiness  commands/waiting.cy.js • 2 flaky tests • 5x-driver-chrome:beta

View Output

Test Artifacts
... > errors > throws when route is never resolved Test Replay
... > errors > throws when waiting for 2nd response to route Test Replay

The first 5 flaky specs are shown, see all 6 specs in Cypress Cloud.

Review all test suite changes for PR #28977 ↗︎

@jennifer-shehane jennifer-shehane merged commit 92d2582 into develop Feb 21, 2024
81 of 82 checks passed
@jennifer-shehane jennifer-shehane deleted the restore-server-gitignore branch February 21, 2024 00:54
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 22, 2024

Released in 13.6.6.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.6, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants