Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix anchor link to changelog 13.6.3 #28957

Merged

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Feb 16, 2024

Additional details

Fixes a badly formatted anchor link to the changelog for cypress@13.6.3. Docusaurus Markdown generates HTML with id="13-6-3" not id="13.6.3" on the Cypress documentation site.

This error has been propagated several times. The links for released versions i.e. up until Cypress 13.6.4 have been corrected through cypress-io/cypress-documentation#5643 on the Cypress documentation site, so it would be nice not to add new wrongly formatted version links in upcoming releases!

Steps to test

Open https://github.com/MikeMcC399/cypress/blob/links/changelog-13-6-3/cli/CHANGELOG.md and click on link to 13.6.3. Note that it now explicitly displays this version and doesn't just go to the top of the page.

How has the user experience changed?

Once the next version of Cypress is released (currently slated as 13.6.5) the link in the changelog will work correctly.

PR Tasks

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399

This comment was marked as resolved.

@jennifer-shehane jennifer-shehane merged commit ad99300 into cypress-io:develop Feb 16, 2024
6 of 8 checks passed
@MikeMcC399 MikeMcC399 deleted the links/changelog-13-6-3 branch February 16, 2024 14:45
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 20, 2024

Released in 13.6.5.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.5, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants