chore: update aws sdk #28712
Merged
chore: update aws sdk #28712
+1,135
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3 (version 8) [run ci] chore: add region to aws s3 bucket [run ci]
| accessKeyId: aws.accessKeyId, | ||
| secretAccessKey: aws.secretAccessKey, | ||
| sessionToken: aws.sessionToken, | ||
| credentials: { |
There was a problem hiding this comment.
Aww the missing piece to why this needed to be reverted: #28379
emilyrohrbough
approved these changes
Jan 12, 2024
mschile
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
While I was investigating why Circle M1s had issues uploading to S3, I decided to update the
aws-sdkfromv2tov3, which is not independent packages and allows us to use@aws-sdk/client-s3for our upload jobs. I used the migration guide via script to update the changes and tweak a few things on our end. This also allows us to updategulp-awspublishto latest since we are now using the newer aws sdk.Steps to test
create-build-artifactsjob in circle and verify the binary is uploaded to S3yarn prepare-release-artifacts --sha <LATEST_DEVELOP_SHA> --version 13.6.3 --dry-runto verify the updated s3 bucket instantiation works. This does not test the actual moving of the binaries, which will need to happen when we release.How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?