Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve types and dist issues with @cypress/puppeteer #28424

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

chrisbreiding
Copy link
Contributor

Additional details

Steps to test

Resolves a couple issues with the initial release of @cypress/puppeteer

  • TypeScript types didn't work correctly for import { setup } from '@cypress/puppeteer'. Needed a better separation of the Node types and support types and for package.json to point to the Node types.
  • Importing into the support file didn't work as documented. Needed to add a root support directory so import '@cypress/puppeteer/support works
  • Fixed some inaccuracies in the README

PR Tasks

Copy link

cypress bot commented Nov 29, 2023

5 flaky tests on run #52586 ↗︎

0 5371 80 0 Flakiness 5

Details:

update 0.1.0 changelog
Project: cypress Commit: 5ba63172e4
Status: Passed Duration: 14:31 💡
Started: Nov 29, 2023 4:00 PM Ended: Nov 29, 2023 4:14 PM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
network stubbing > waiting and aliasing > yields the expected interception when two requests are raced Test Replay
Flakiness  commands/storage.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
src/cy/commands/storage > #getAllLocalStorage > gets local storage from all origins Test Replay
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-chrome:beta

View Output

Test Artifacts
... > correctly returns currentRetry Test Replay
... > correctly returns currentRetry Test Replay
... > correctly returns currentRetry Test Replay

Review all test suite changes for PR #28424 ↗︎

@chrisbreiding chrisbreiding merged commit 72225db into develop Nov 29, 2023
82 of 84 checks passed
@chrisbreiding chrisbreiding deleted the crb/cy-puppeteer-0.1.0-fixes branch November 29, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants