Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no longer swallow stderr logs on linux #28380

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

emilyrohrbough
Copy link
Member

@emilyrohrbough emilyrohrbough commented Nov 21, 2023

On Linux we were swallowing stderr logs (see #24713) and consequently also unintentionally swallowing any cypress app debug logs that weren't defined as cypress:* + cypress:electron. (i.e. not including cypress:electron meant no debug logs from the app).

cli/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

cypress bot commented Nov 30, 2023

36 flaky tests on run #52635 ↗︎

0 28304 1347 0 Flakiness 36

Details:

Merge branch 'develop' into em/enable-linux-logs
Project: cypress Commit: 033ab9f37f
Status: Passed Duration: 19:20 💡
Started: Nov 30, 2023 10:25 PM Ended: Nov 30, 2023 10:44 PM
Flakiness  e2e/origin/basic_login.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
basic login > visit primary first > logs in with idp redirect
    </td>
  </tr></table>
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary
    </td>
  </tr></table>
Flakiness  e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
cy.origin assertions > #consoleProps > .should() and .and()
    </td>
  </tr></table>
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output

Test Artifacts
... > correctly returns currentRetry
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/52635/overview/5620d40f-a02e-4c9f-adfc-17f98a1eb911?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test">
        ... > correctly returns currentRetry
      </a>
    </td>
    <td>
      
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/52635/overview/251cd848-c7c4-486f-8199-21585809cf93?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test">
        ... > correctly returns currentRetry
      </a>
    </td>
    <td>
      
    </td>
  </tr></table>
Flakiness  scaffold-component-testing.cy.ts • 1 flaky test • launchpad-e2e

View Output

Test Artifacts
scaffolding component testing > create-react-app > scaffolds component testing for Create React App v5 project Test Replay Screenshots

The first 5 flaky specs are shown, see all 20 specs in Cypress Cloud.

Review all test suite changes for PR #28380 ↗︎

@chrisbreiding chrisbreiding merged commit f53ca92 into develop Dec 5, 2023
82 of 84 checks passed
@chrisbreiding chrisbreiding deleted the em/enable-linux-logs branch December 5, 2023 15:12
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 5, 2023

Released in 13.6.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

console.error is printed properly on a mac terminal, but not on linux terminal Issues using DEBUG var env
3 participants