Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update mochaEvent snapshots to be auto-generated #28224

Merged
merged 12 commits into from Nov 6, 2023

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Nov 2, 2023

Additional details

Updated the packages/app mochaEvent snapshots to be auto-generated instead of requiring them to be manually updated.

  • Setting the CYPRESS_SNAPSHOT_UPDATE env variable or running yarn cypress:run:e2e:update:snapshots from the packages/app directory will update the snapshots
  • Fixed some flake we were receiving due to multiple mocha:start events being sent for cy-in-cy tests
  • The snapshots are now stored in a /snapshots folder

Steps to test

Verified the new .json files are equivalent to the old snapshot files

How has the user experience changed?

PR Tasks

Copy link

cypress bot commented Nov 2, 2023

4 flaky tests on run #52161 ↗︎

0 5307 136 0 Flakiness 4

Details:

Merge branch 'develop' into mschile/mocha_events_snapshots
Project: cypress Commit: 1f1b008623
Status: Passed Duration: 12:53 💡
Started: Nov 6, 2023 9:01 PM Ended: Nov 6, 2023 9:14 PM
Flakiness  e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
cy.origin assertions > #consoleProps > .should() and .and() Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output

Review all test suite changes for PR #28224 ↗︎

Copy link
Contributor

@chrisbreiding chrisbreiding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement 💯

@mschile mschile merged commit 9f19f9a into develop Nov 6, 2023
81 of 82 checks passed
@mschile mschile deleted the mschile/mocha_events_snapshots branch November 6, 2023 23:54
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 8, 2023

Released in 13.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants