feat: add support for angular 17 #28152
Conversation
Passing run #52125 ↗︎
Details:
Review all test suite changes for PR #28152 ↗︎ |
|||||||||||||||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
You need to write separately in the original PR text, otherwise GitHub doesn't pick it up and won't link it automatically, to close it when the PR is closed.
from https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue |
|
According to https://angular.io/guide/versions only Angular Also Angular Since removal would be a breaking change this might need to be reserved for a later Cypress major version release. (It would however be possible to remove the old system tests and leave the version check without causing a breaking change.) |
There was a problem hiding this comment.
We don't need system tests for both angular-16 and angular-16.1 anymore.
| '@angular/platform-browser/testing': require.resolve('@angular/platform-browser/testing'), | ||
| '@angular/platform-browser': require.resolve('@angular/platform-browser'), | ||
| '@angular/platform-browser-dynamic/testing': require.resolve('@angular/platform-browser-dynamic/testing'), | ||
| '@angular/platform-browser-dynamic': require.resolve('@angular/platform-browser-dynamic'), |
There was a problem hiding this comment.
Changes in angular 17 to zone.js/testing cause the shared cypress.config.ts from project-fixtures/angular/cypress.config.ts to be invalid so needed create a unique one here
jordanpowell88
changed the title
| **Features:** | ||
|
|
||
| - Adds Component Testing support for Angular version 17. Addresses [#28153](https://github.com/cypress-io/cypress/issues/28153). | ||
|
|
There was a problem hiding this comment.
Since this is a feature we should bump the next version number to 13.5.0, right?
There was a problem hiding this comment.
This check should have ensured this was bumped before merging...
* feat(webpack-dev-server): add support for angular 17 * update changelog * fix broken spec pattern * update to rc 2 for cli * remove = from dependency minVersion lists * update angular 17 rc version and update dep test * add projectDirFolder to fixtures for angular-17 * resolve broken system tests * update ct project dir angular version
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
dependencies.tsfile when defining CT frameworks #27475Additional details
This PR adds support for Angular 17 CT set to release on November 7. AFAIK their are no breaking changes and just requires a bump in the scaffold deps + system tests example for version 17. This PR currently uses the Angular 17 Release Candidate to validate it works. We will need to change this before merging
Steps to test
Run
yarn devand open an angular 17 project using using the Release candidate.How has the user experience changed?
No changes expected
PR Tasks
cypress-documentation?type definitions?