Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with proxy correlations and web/shared workers #28105

Merged
merged 15 commits into from
Oct 24, 2023

Conversation

ryanthemanuel
Copy link
Collaborator

Additional details

We fixed service workers on #28060 however it appears that workers need to be handled differently in terms of target tracking (we need to use Target.setAutoAttach instead of Target.setDiscoverTargets). This PR handles web workers in that fashion and ensures that shared workers work as well.

Steps to test

I added a few system tests to cover all of the scenarios.

How has the user experience changed?

n/a

PR Tasks

@ryanthemanuel ryanthemanuel requested review from cacieprins, chrisbreiding and mschile and removed request for cacieprins October 20, 2023 20:44
packages/server/lib/browsers/browser-cri-client.ts Outdated Show resolved Hide resolved
packages/server/lib/browsers/utils.ts Outdated Show resolved Hide resolved
@cypress
Copy link

cypress bot commented Oct 23, 2023

33 flaky tests on run #51831 ↗︎

0 28150 1345 0 Flakiness 33

Details:

fix tests
Project: cypress Commit: 82c0e5ab9c
Status: Passed Duration: 19:09 💡
Started: Oct 24, 2023 2:53 AM Ended: Oct 24, 2023 3:12 AM
Flakiness  project-setup.cy.ts • 2 flaky tests • launchpad-e2e

View Output Video

Test Artifacts
... > shows the configuration setup page when selecting e2e tests Test Replay Output Screenshots
Launchpad: Setup Project > openLink > opens docs link in the default browser Test Replay Output Screenshots
Flakiness  global-mode.cy.ts • 1 flaky test • launchpad-e2e

View Output Video

Test Artifacts
... > can be opened Test Replay Output Screenshots
Flakiness  e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
cy.origin assertions > #consoleProps > .should() and .and() Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
Flakiness  commands/files.cy.js • 2 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > has implicit existence assertion, retries and throws a specific error when file does not exist for null encoding Test Replay Output
... > throws when there is an error writing the file Test Replay Output

The first 5 flaky specs are shown, see all 19 specs in Cypress Cloud.

Review all test suite changes for PR #28105 ↗︎

@ryanthemanuel ryanthemanuel merged commit dbd2139 into develop Oct 24, 2023
80 of 82 checks passed
@ryanthemanuel ryanthemanuel deleted the ryanm/fix/proxy-and-webworkers branch October 24, 2023 03:26
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 24, 2023

Released in 13.3.3.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.3.3, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requests that are cached in web and shared workers can be improperly correlated in the proxy
3 participants