Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Spellcheck #27964

Merged
merged 6 commits into from
Oct 11, 2023
Merged

Conversation

calvinballing
Copy link
Contributor

Fixes various typos. The first and third commits may impact functionality. The second is batched together as it affects a snapshot. The fourth commit is a general bucket for all the other changes (test descriptions, code comments, variable names, etc.)

Additional details

n/a

Steps to test

n/a

How has the user experience changed?

n/a

PR Tasks

@cypress-app-bot
Copy link
Collaborator

@calvinballing calvinballing changed the title Spellcheck refactor:Spellcheck Oct 3, 2023
@calvinballing calvinballing changed the title refactor:Spellcheck refactor: Spellcheck Oct 3, 2023
@calvinballing calvinballing marked this pull request as ready for review October 3, 2023 18:41
@calvinballing
Copy link
Contributor Author

I don't understand Snyk works, so I'm not sure how to address that two of the Snyk tests are failing due to:

Input required and not supplied: token

@dkasper-was-taken
Copy link
Contributor

I don't understand Snyk works, so I'm not sure how to address that two of the Snyk tests are failing due to:

Input required and not supplied: token

@calvinballing There are currently some limitations to the Synk scan when it comes to contributor PRs that we are working to resolve. For the time being you can ignore the failure.

@calvinballing
Copy link
Contributor Author

Not sure what causes these jobs to hang in the Expected — Waiting for status to be reported and Pending — Your job is on hold on CircleCI! states. Is there more I need to do on my end to keep this moving forward?

@mschile mschile self-assigned this Oct 10, 2023
@mschile mschile self-requested a review October 10, 2023 20:02
@jennifer-shehane jennifer-shehane merged commit 34c8b1f into cypress-io:develop Oct 11, 2023
64 of 66 checks passed
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 11, 2023

Released in 13.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.3.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants