fix: optimize reduce addCypressToWebpackEslintRulesInPlace

[Connormiha]

Additional details

I just optimized reduce to avoid creating new object each iteration. And set O(n) instead of O(n*n).

Steps to test

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

[CLAassistant]

All committers have signed the CLA.

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[cypress]

24 flaky tests on run #51046 ↗︎

0

28124

1345

0

24

Details:

fix: optimize reduce addCypressToWebpackEslintRulesInPlace
Project: cypress	Commit: ca2e7597e7
Status: Passed	Duration: 18:37 💡
Started: Sep 15, 2023 11:52 AM	Ended: Sep 15, 2023 12:11 PM

  project-setup.cy.ts • 1 flaky test • launchpad-e2e

View Output Video

Test		Artifacts
... > skips the setup steps when choosing component tests to run		Test Replay Output Screenshots

  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test		Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs		Test Replay Output Screenshots

  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test		Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary		Output

  e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test		Artifacts
cy.origin assertions > #consoleProps > .should() and .and()		Output

  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test		Artifacts
... > correctly returns currentRetry		Output
... > correctly returns currentRetry		Output
... > correctly returns currentRetry		Output

The first 5 flaky specs are shown, see all 12 specs in Cypress Cloud.

Review all test suite changes for PR #27819 ↗︎

[nagash77]

Hi @Connormiha I am seeing some linting failures in the build. Can you please check out our contributing guide linting standards and update your PR? I am also seeing a failing check-ts check.

[Connormiha]

Hi @Connormiha I am seeing some linting failures in the build. Can you please check out our contributing guide linting standards and update your PR? I am also seeing a failing check-ts check.

I updated, but it seems the tests didn't restart.