Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 13.0.0 release #27690

Merged
merged 2 commits into from
Aug 29, 2023
Merged

chore: 13.0.0 release #27690

merged 2 commits into from
Aug 29, 2023

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Aug 29, 2023

Additional details

In addition to boilerplate for the 13.0.0 release, this also adds handling for hitting rate limits to the get-binary-release-data script.

Steps to test

How has the user experience changed?

PR Tasks

@cypress
Copy link

cypress bot commented Aug 29, 2023

24 flaky tests on run #50620 ↗︎

0 28090 1355 0 Flakiness 24

Details:

handle github rate limits when fetching pr data
Project: cypress Commit: c705f5f982
Status: Passed Duration: 20:26 💡
Started: Aug 29, 2023 1:39 PM Ended: Aug 29, 2023 2:00 PM
Flakiness  cypress/e2e/e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
cy.origin assertions > #consoleProps > .should() and .and() Output
Flakiness  cypress/e2e/cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
Flakiness  cypress/e2e/specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Output Screenshots
Flakiness  cypress/e2e/debug.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App - Debug Page > shows running and updating build Test Replay Output Screenshots
Flakiness  src/navigation/SidebarNavigation.cy.tsx • 1 flaky test • app-ct

View Output Video

Test Artifacts
SidebarNavigation > expands the bar when clicking the expand button Test Replay Output Screenshots

The first 5 flaky specs are shown, see all 12 specs in Cypress Cloud.

Review all test suite changes for PR #27690 ↗︎

@chrisbreiding
Copy link
Contributor Author

@ryanthemanuel, @mike-plummer I added onto this PR to handle rate limits we are hitting since we're fetching so many PRs with this release, so that probably needs a review.

@@ -61,7 +122,7 @@ const getReleaseData = async (latestReleaseInfo) => {
const prsInRelease = []
const commits = []

await Promise.all(semanticCommits.map(async (semanticResult) => {
await Bluebird.each(semanticCommits, (async (semanticResult) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This alone might prevent hitting rate limits since it makes the requests serial instead of racing them, but there's also the error handling just in case.

@ryanthemanuel ryanthemanuel merged commit 91d2845 into develop Aug 29, 2023
38 of 70 checks passed
@ryanthemanuel ryanthemanuel deleted the 13.0.0-release branch August 29, 2023 13:43
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 29, 2023

Released in 13.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants