Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove flaky Percy snapshot from global-mode spec #27526

Merged
merged 1 commit into from Aug 11, 2023

Conversation

astone123
Copy link
Contributor

This PR removes a Percy snapshot from the global-mode spec because it flakes on showing the version number. We already make a bunch of assertions on the content here.

Flake example: https://percy.io/cypress-io/cypress/builds/29594711/changed/1641650644?browser=chrome&browser_ids=38&subcategories=unreviewed%2Cchanges_requested&viewLayout=side-by-side&viewMode=new&width=800&widths=400%2C800

@cypress
Copy link

cypress bot commented Aug 11, 2023

6 flaky tests on run #49806 ↗︎

0 694 26 0 Flakiness 6

Details:

chore: remove flaky Percy snapshot from global-mode spec
Project: cypress Commit: 195f02f738
Status: Passed Duration: 13:22 💡
Started: Aug 11, 2023 6:01 PM Ended: Aug 11, 2023 6:15 PM
Flakiness  debug.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App - Debug Page > shows running and updating build Output Screenshots Video
Flakiness  create-from-component.cy.ts • 2 flaky tests • app-e2e

View Output Video

Test Artifacts
... > runs generated spec Output Screenshots Video
... > runs generated spec Output Screenshots Video
Flakiness  runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
... > displays a list of recorded runs if a run has been recorded Output Screenshots Video
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video
Flakiness  cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tripped over this one yesterday. Not sure why the cy logo is missing sometimes 🤷🏻

@astone123 astone123 merged commit df6d1c2 into develop Aug 11, 2023
83 of 85 checks passed
@astone123 astone123 deleted the astone123/global-mode-percy-flake branch August 11, 2023 19:02
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 15, 2023

Released in 12.17.4.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.17.4, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants