Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix web worker creation within spec frame #27313

Merged
merged 1 commit into from Jul 17, 2023

Conversation

chrisbreiding
Copy link
Contributor

Additional details

The content security policy set for the spec frame is primarily intended to prevent additional scripts from being added to it. Disallowing web workers was an unintended consequence of adding the policy, so this loosens up the restriction and allows web workers to be created and used within the spec frame.

Steps to test

How has the user experience changed?

PR Tasks

@cypress
Copy link

cypress bot commented Jul 17, 2023

Passing run #48879 ↗︎

0 214 20 0 Flakiness 0

Details:

fix: fix web worker creation within spec frame
Project: cypress Commit: 591c04b34d
Status: Passed Duration: 10:14 💡
Started: Jul 17, 2023 3:09 PM Ended: Jul 17, 2023 3:19 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@chrisbreiding chrisbreiding merged commit 8fc59f4 into develop Jul 17, 2023
80 of 83 checks passed
@chrisbreiding chrisbreiding deleted the issue-27298-web-workers-csp branch July 17, 2023 15:19
ryanthemanuel pushed a commit that referenced this pull request Jul 19, 2023
Co-authored-by: Stokes Player <stokes@cypress.io>
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
Co-authored-by: Jordan <jordan@jpdesigning.com>
Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
Co-authored-by: Chris Breiding <chrisbreiding@gmail.com>
fix: Fix web worker creation within spec frame (#27313)
fix: Handle privileged commands arg mutation (#27282)
fix(webpack-dev-server): add typeRoots to generated tsconfig for angular (#27117)
fix memory import (#27324)
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 20, 2023

Released in 12.17.2.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.17.2, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress 12.15 broke the ability to run Web Workers in cypress tests
3 participants