Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle evaled privileged commands #27267

Merged
merged 6 commits into from Jul 12, 2023

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Jul 11, 2023

Additional details

The heuristics for evaluating needed to be updated to handle when spec code is evaled within the spec frame. In particular, it failed to validate a privileged command if it was within a callback (for a command like .then) that was within the evaled spec code.

Steps to test

How has the user experience changed?

PR Tasks

@cypress
Copy link

cypress bot commented Jul 11, 2023

4 flaky tests on run #48763 ↗︎

0 5321 81 0 Flakiness 4

Details:

handle within in firefox
Project: cypress Commit: 3ea000f166
Status: Passed Duration: 13:51 💡
Started: Jul 12, 2023 3:44 PM Ended: Jul 12, 2023 3:58 PM
Flakiness  e2e/origin/commands/navigation.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output Video

Test Artifacts
cy.origin navigation > #consoleProps > .go() Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-chrome:beta

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@chrisbreiding chrisbreiding merged commit 4c0371f into develop Jul 12, 2023
76 of 78 checks passed
@chrisbreiding chrisbreiding deleted the issue-27097-writefile-error branch July 12, 2023 17:09
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 20, 2023

Released in 12.17.2.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.17.2, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cy.writeFiles runs into errors
3 participants