Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update contributing docs #27173

Merged
merged 2 commits into from
Jun 30, 2023
Merged

chore: update contributing docs #27173

merged 2 commits into from
Jun 30, 2023

Conversation

lmiller1990
Copy link
Contributor

Additional details

Updated docs.

Steps to test

How has the user experience changed?

PR Tasks

@lmiller1990 lmiller1990 mentioned this pull request Jun 30, 2023
Closed
@cypress
Copy link

cypress bot commented Jun 30, 2023 •
edited

Passing run #48478 ↗︎

0 214 20 0 Flakiness 0

Details:

Update wording
Project: cypress Commit: f28f8a7bb7
Status: Passed Duration: 10:10 💡
Started: Jun 30, 2023 1:26 PM Ended: Jun 30, 2023 1:36 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@MikeMcC399
Copy link
Contributor

I was able to run

npm start --prefix ../cypress-example-kitchensink & yarn cypress:run --project ../cypress-example-kitchensink

successfully from #27068.

MikeMcC399
MikeMcC399 approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you!

@mike-plummer mike-plummer merged commit 7e68034 into develop Jun 30, 2023
77 of 78 checks passed
@mike-plummer mike-plummer deleted the issue-27068 branch June 30, 2023 13:49
@MikeMcC399 MikeMcC399 mentioned this pull request Jul 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marktnoonan marktnoonan marktnoonan approved these changes

@mike-plummer mike-plummer mike-plummer approved these changes

@MikeMcC399 MikeMcC399 MikeMcC399 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contributing > Getting started --run-project fails with unknown option
4 participants
@lmiller1990 @MikeMcC399 @marktnoonan @mike-plummer