fix: Handle more argument types in privileged commands #27166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbreiding
commented
Jun 29, 2023
Comment on lines
+6367
to
+6378
| type TypedArray = | ||
| | Int8Array | ||
| | Uint8Array | ||
| | Uint8ClampedArray | ||
| | Int16Array | ||
| | Uint16Array | ||
| | Int32Array | ||
| | Uint32Array | ||
| | Float32Array | ||
| | Float64Array | ||
|
|
||
| type FileReference = string | BufferType | FileReferenceObject | TypedArray |
There was a problem hiding this comment.
This is a correction for this type.cy.selectFile() can take a TypedArray as an argument.
chrisbreiding
commented
Jun 29, 2023
Comment on lines
+25
to
+47
| // hashes a string in the same manner as is in the privileged channel. | ||
| // unfortunately this can't be shared because we want to reduce the surface | ||
| // area in the privileged channel, which uses closured references to | ||
| // globally-accessible functions | ||
| // source: https://github.com/bryc/code/blob/d0dac1c607a005679799024ff66166e13601d397/jshash/experimental/cyrb53.js | ||
| function hash (str) { | ||
| const seed = 0 | ||
| let h1 = 0xdeadbeef ^ seed | ||
| let h2 = 0x41c6ce57 ^ seed | ||
|
|
||
| for (let i = 0, ch; i < str.length; i++) { | ||
| ch = str.charCodeAt(i) | ||
| h1 = Math.imul(h1 ^ ch, 2654435761) | ||
| h2 = Math.imul(h2 ^ ch, 1597334677) | ||
| } | ||
| h1 = Math.imul(h1 ^ (h1 >>> 16), 2246822507) | ||
| h1 ^= Math.imul(h2 ^ (h2 >>> 13), 3266489909) | ||
| h2 = Math.imul(h2 ^ (h2 >>> 16), 2246822507) | ||
| h2 ^= Math.imul(h1 ^ (h1 >>> 13), 3266489909) | ||
|
|
||
| return `${4294967296 * (2097151 & h2) + (h1 >>> 0)}` | ||
| } | ||
|
|
There was a problem hiding this comment.
Moved here without change from the server
chrisbreiding
commented
Jun 29, 2023
| @@ -25,7 +25,7 @@ export default (Commands, Cypress, cy, state) => { | |||
| // privileged commands need to send any and all args, even if not part | |||
| // of their API, so they can be compared to the args collected when the | |||
| // command is invoked | |||
| const userArgs = trimUserArgs([file, encoding, _.isObject(userOptions) ? { ...userOptions } : undefined, ...extras]) | |||
| const userArgs = [file, encoding, _.isObject(userOptions) ? { ...userOptions } : undefined, ...extras] | |||
There was a problem hiding this comment.
Trimming (and hashing) the user args has been moved into the runPrivilegedCommand function.
AtofStryker
approved these changes
Jun 29, 2023
mjhenkes
approved these changes
Jun 29, 2023
34 flaky tests on run #48405 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| network stubbing > intercepting request > can delay and throttle a StaticResponse |
Output
|
|
e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| cy.origin assertions > #consoleProps > .should() and .and() |
Output
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
runs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| ... > opens the run page if a run is clicked |
Output
Screenshots
Video
|
|
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Output
Screenshots
Video
|
|
The first 5 flaky specs are shown, see all 22 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Privileged command argument comparison was failing with types like ArrayBuffer because the invocation argument hashing was done client-side while the execution argument hashing was done server-side. I moved the execution hashing to the client-side, which ensures that the argument hashes will be equal for equal arguments.
I checked the types of arguments each privileged command accepts and added tests to ensure they are all covered.
PR Tasks
cypress-documentation?type definitions?