Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adding log false to backend stubs #27129

Merged
merged 6 commits into from
Jul 6, 2023
Merged

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Jun 23, 2023

Additional details

While comparing the performance between the protocol branch and develop we noticed some tests were faster on the protocol branch due to not logging the cy.stub commands. This change add the log(false) to develop so the times can be accurately compared.

Steps to test

n/a

How has the user experience changed?

n/a

PR Tasks

@mschile mschile changed the title test: adding stub backend log false test: adding log false to backend stubs Jun 23, 2023
@cypress
Copy link

cypress bot commented Jun 23, 2023

11 flaky tests on run #48535 ↗︎

0 9764 1025 0 Flakiness 11

Details:

Merge branch 'develop' into mschile/stub_log_false
Project: cypress Commit: f3beb68a36
Status: Passed Duration: 14:26 💡
Started: Jul 2, 2023 2:54 PM Ended: Jul 2, 2023 3:08 PM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output Video
Flakiness  e2e/origin/commands/navigation.cy.ts • 1 flaky test • 5x-driver-chrome

View Output Video

Test Artifacts
cy.origin navigation > #consoleProps > .go() Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-chrome

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
Flakiness  commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output Video
... > with `times` > only uses each handler N times Output Video
... > stops waiting when an xhr request is canceled Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-webkit

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mschile mschile merged commit 213afde into develop Jul 6, 2023
76 of 78 checks passed
@mschile mschile deleted the mschile/stub_log_false branch July 6, 2023 18:38
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 10, 2023

Released in 12.17.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.17.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants