Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing utm parameters for cloud links to Debug page #26556

Merged
merged 7 commits into from
Apr 21, 2023

Conversation

warrensplayer
Copy link
Contributor

@warrensplayer warrensplayer commented Apr 20, 2023

Four links on the Debug page were missing UTM parameters needed for measuring impact of certain features

  • artifact links
  • "View in Cypress Cloud" link in the header
  • Link to the project in the run navigation limit banner
  • Link to the run in the spec limit banner

Additional details

Steps to test

Verify by reviewing the E2E and CT tests

How has the user experience changed?

The user experience was not affected.

PR Tasks

@warrensplayer warrensplayer requested a review from a team April 21, 2023 13:55
@warrensplayer warrensplayer marked this pull request as ready for review April 21, 2023 13:55
Copy link
Contributor

@astone123 astone123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one typo I noticed

packages/app/src/debug/utils/debugArtifacts.ts Outdated Show resolved Hide resolved
@cypress
Copy link

cypress bot commented Apr 21, 2023

8 flaky tests on run #45735 ↗︎

0 4581 922 0 Flakiness 8

Details:

Using computed and adding constant for utm_medium value
Project: cypress Commit: 75eb76226f
Status: Passed Duration: 14:14 💡
Started: Apr 21, 2023 4:04 PM Ended: Apr 21, 2023 4:18 PM
Flakiness  project-setup.cy.ts • 1 flaky test • launchpad-e2e

View Output Video

Test Artifacts
... > skips the setup page when choosing e2e tests to run Output Screenshots Video
Flakiness  commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output Video
... > with `times` > only uses each handler N times Output Video
... > stops waiting when an xhr request is canceled Output Video
Flakiness  commands/waiting.cy.js • 1 flaky test • 5x-driver-webkit

View Output Video

Test Artifacts
... > errors > throws waiting for the 3rd response Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-webkit

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@warrensplayer warrensplayer merged commit c86a97e into develop Apr 21, 2023
75 of 77 checks passed
@warrensplayer warrensplayer deleted the stokes/debug_links_missing_utm_params branch April 21, 2023 17:51
tgriesser added a commit that referenced this pull request May 3, 2023
* feat/protocol:
  refactor: migrate from windi to tailwind (#26516)
  chore: update v8 generation vars so that from scratch depends implies updating the metafile (#26472)
  chore: Update Vite to 4.3.0 (#26553)
  fix: unify cdp approach to fix devtools in electron (#26573)
  dependency(deps): update dependency deps-ok to v1.4.1 🌟 (#26612)
  chore: update 12.11.0 release date (#26587)
  chore: 12.11.0 release (#26582)
  chore: implement experimental ESM stub/spy for Vite (#26536)
  chore: try triggering mouseleave on buttons to ensure that tooltips aren't showing (#26524)
  chore: add support for Angular 16 (#26052)
  chore: upgrade Vue to 3.2.47 (#26555)
  chore: Update v8 snapshot cache (#26537)
  chore: add missing utm parameters for cloud links to Debug page (#26556)
  chore: update stalebot to respect new labels and up process rate (#26552)
  fix: don't display run passing status if Cloud org is over run limit (#26533)
  chore: update vm2 to 3.9.17 (#26534)
  feat: display a limit warning on the run navigation component when there are 100 total runs (#26523)
  chore: Update v8 snapshot cache (#26476)
  chore: upgrade vm2 (#26495)
  fix: Treat Video compression 0 as false.  (#26503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants