fix: make isFocusedOrInFocused check shadow roots #26207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kgroat
changed the title
kgroat
force-pushed
the
issue-26198-check-shadow-roots-for-focus
branch
from
bc8e4a4
to
8d7622d
Compare
1 failed and 30 flaky tests on run #44937 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| with multiple test results > mounts correctly for single groups |
Output
Video
|
|
create-from-component.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| ... > runs generated spec |
Output
Screenshots
Video
|
|
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Output
Screenshots
Video
|
|
cypress-in-cypress-component.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress In Cypress CT > default config > redirects to the specs list with error if a spec is not found |
Output
Screenshots
Video
|
|
cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution |
Output
Screenshots
Video
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| network stubbing > intercepting request > can delay and throttle a StaticResponse |
Output
|
|
The first 5 flaky specs are shown, see all 18 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
@lmiller1990 I see that there are several errors from the checks running. Are they blocking review? If so, I don't see how they're caused by my code change. What do I need to do to resolve them? |
kgroat
requested review from
emilyrohrbough
and removed request for
lmiller1990
|
Oh, I clicked the "re-request review" button and it removed @lmiller1990 as a reviewer -- not sure why that happened; I'll make sure not to click that button again 😅 |
Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
Because shadowRoots don't have a getSelection function
kgroat
force-pushed
the
issue-26198-check-shadow-roots-for-focus
branch
from
42de3a9
to
27bfdc9
Compare
emilyrohrbough
approved these changes
Mar 24, 2023
chrisbreiding
approved these changes
Mar 27, 2023
|
Is there any chance of this getting merged before the release planned tomorrow? |
|
Two approvals, CI green, let's ship it! Thanks for the contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Currently, checking for focus doesn't look inside of shadow roots. This causes issues such as the
typecommand always firing theclickeven if the element has focus.This PR changes the behavior of
isFocusedOrInFocusedto check if the element passed in is anactiveElementinside of a shadow root.Steps to test
Clone https://github.com/kgroat/cypress-type-repro and run the component test. Before these changes, it fails, but after it passes.
How has the user experience changed?
N/A
PR Tasks
cypress-documentation?type definitions?