-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(grep): references to cypress-grep #26108
Conversation
Reopening a simplified version of this PR without tests (as the tests were blocking the original PR) |
@@ -228,7 +228,7 @@ if (!Cypress.grep) { | |||
* // remove all current grep settings | |||
* // and run all tests | |||
* Cypress.grep() | |||
* @see "Grep from DevTools console" https://github.com/cypress-io/cypress-grep#devtools-console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
system-tests/projects/nx-monorepo was this file added on accident?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
a74aebd
to
c5c318f
Compare
Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
28 flaky tests on run #44752 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
network stubbing > intercepting request > can delay and throttle a StaticResponse |
Output
|
e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox
Test | Artifacts | |
---|---|---|
cy.origin assertions > #consoleProps > .should() and .and() |
Output
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
Test | Artifacts | |
---|---|---|
... > correctly returns currentRetry |
Output
|
|
... > correctly returns currentRetry |
Output
|
|
... > correctly returns currentRetry |
Output
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
Test | Artifacts | |
---|---|---|
... > correctly returns currentRetry |
Output
Video
|
|
... > correctly returns currentRetry |
Output
Video
|
|
... > correctly returns currentRetry |
Output
Video
|
create-from-component.cy.ts • 1 flaky test • app-e2e
Test | Artifacts | |
---|---|---|
... > runs generated spec |
Output
Screenshots
Video
|
The first 5 flaky specs are shown, see all 17 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Additional details
fix references still pointing to
cypress-grep
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?