cy.root ignores timeout option

[marcandre]

Current behavior

Passing a timeout option to cy.root has no effect.

Desired behavior

Like get and al., it should retry for the given timeout duration.

Note: there's a separate bug with root not retrying at all when called from within. This seems different but may be related.

Test code to reproduce

From this demo:

describe("page", () => {
  beforeEach(() => {
    cy.visit("https://example.cypress.io");
    delayedHelloAfter(7);
  });

  it("`root` retries using the default so this test fails (good)", () => {
    cy.root().should("contain", "Hello");
  });

  it("`root` does not respect the `timeout` options so this test fails too (bad)", () => {
    cy.root({ timeout: 10000 }).should("contain", "Hello");
  });
  it("get('html') does respect the `timeout` options so this test passes (good)", () => {
    cy.get("html", { timeout: 10000 }).should("contain", "Hello");
  });
});

function delayedHelloAfter(seconds) {
  cy.window().then((w) => {
    w.eval(`setTimeout(() => {
        document.querySelector('.banner .container').innerHTML = '<p> Hello, world!</p>'
      }, ${seconds} * 1000)
      console.log("ok")
      `);
  });
}

Cypress Version

9.3.1 & 9.4.0

Other

No response

[sainthkh]

Confirmed that this fails.

Thank you for the reproducible example.

[cypress-bot]

The code for this is done in cypress-io/cypress#20817, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

Released in 9.5.4.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.5.4, please open a new issue.