Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate configuration values coming from the CLI or env vars #1783

Closed
brian-mann opened this issue May 28, 2018 · 3 comments · Fixed by #1784
Closed

Validate configuration values coming from the CLI or env vars #1783

brian-mann opened this issue May 28, 2018 · 3 comments · Fixed by #1784
Assignees
Milestone

Comments

@brian-mann
Copy link
Member

We currently validate config.json settings to ensure they of the correct types.

However if you override these configuration values through env vars like CYPRESS_BASE_URL or cypress run --config baseUrl=foo we don't validate those.

We should additionally validate these after merging in overrides.

@brian-mann brian-mann added this to the 3.0.0 milestone May 28, 2018
@brian-mann brian-mann self-assigned this May 28, 2018
@bahmutov
Copy link
Contributor

bahmutov commented May 28, 2018 via email

@brian-mann
Copy link
Member Author

We already do the validation, but we do it before merging in values coming from the CLI or Env Vars - so those are potentially missed.

brian-mann added a commit that referenced this issue May 28, 2018
* fixes #1783 validate configuration values after they're set from CLI + Env Vars

* fixes #1754 remove screenshotOnHeadlessFailure and rename trashAssetsBeforeHeadlessRuns

* derp copypasta fail
@brian-mann
Copy link
Member Author

Released in 3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants