-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate configuration values coming from the CLI or env vars #1783
Milestone
Comments
Hmm sounds like a job for a json schema!
…Sent from my iPhone
On May 27, 2018, at 22:55, Brian Mann ***@***.***> wrote:
We currently validate config.json settings to ensure they of the correct types.
However if you override these configuration values through env vars like CYPRESS_BASE_URL or cypress run --config baseUrl=foo we don't validate those.
We should additionally validate these after merging in overrides.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
We already do the validation, but we do it before merging in values coming from the CLI or Env Vars - so those are potentially missed. |
brian-mann
added a commit
that referenced
this issue
May 28, 2018
brian-mann
added a commit
that referenced
this issue
May 28, 2018
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently validate
config.json
settings to ensure they of the correct types.However if you override these configuration values through env vars like
CYPRESS_BASE_URL
orcypress run --config baseUrl=foo
we don't validate those.We should additionally validate these after merging in overrides.
The text was updated successfully, but these errors were encountered: