-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page load timeout will not fail the test if page is in redirection loop #14445
Labels
Comments
Yah that's a good one. I'm not sure that it's the pageLoadTimeout so much as the commands attempting to find the DOM elements that should timeout. The |
4 tasks
The code for this is done in cypress-io/cypress#14643, but has yet to be released. |
Released in v7.0.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Current behavior
Page load timeout will not stop the test if page is in redirection loop. The test may run forever. No log output is generated indicating what is happening.
Video: https://github.com/henrikauppinen/cypress-redirect-loop/blob/main/cypress/videos/redirect-loop.spec.js.mp4
The problem is obvious when looking at the UI but when this happens in headless mode in CI it may be extremely difficult to detect as the outcome may be just a long-running cypress process killed by CI.
We had a situation where tests completed successfully locally in headed mode and failed in CI. There was an oversight in test mocks and the application under test behaved differently in CI with drastically different performance constraints.
Desired behavior
Page load timeout should trigger and stop the test even when page redirects continuously.
Test code to reproduce
https://github.com/henrikauppinen/cypress-redirect-loop
Versions
Confirmed with 5.4 until most recent 6.2.1 version.
The text was updated successfully, but these errors were encountered: