Test SpawnProcess#send_signal in specs #815
Merged
+66
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvz
force-pushed
the
improve-signal-tests
branch
5 times, most recently
from
df54400 to
ed873dd
Compare
- Test both success and failure scenarios for SpawnProcess#send_signal in specs - Remove failure scenario from cukes and improve remaining success scenario
mvz
force-pushed
the
improve-signal-tests
branch
from
ed873dd to
116e007
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move edge-case tests for
SpawnProcess#find_signalto the rspec suite.Details
SpawnProcess#send_signalin specsMotivation and Context
Improves the value of the cucumber scenarios as documentation, and the value of the specs to provide fast feedback during development.
How Has This Been Tested?
Ran the specs. CI will do the rest.
Types of changes
Checklist: