feat: add support for team review requests #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @andrii-bodnar, we are starting to use Crowdin at my company and we have a need to request team reviews when using this action. Would love if you or someone at Crowdin could review this PR. And let me know your thoughts. Thank you so much! |
fernandogelin
force-pushed
the
feat/team-reviewers
branch
from
8e0f73c
to
6527d63
Compare
|
Hi @fernandogelin, thanks a lot for the contribution! It's a nice feature for this GH Action! 🚀 |
andrii-bodnar
approved these changes
Jul 24, 2023
kodiakhq bot
pushed a commit
to weareinreach/InReach
that referenced
this pull request
Jul 24, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Codesee-io/codesee-action](https://togithub.com/Codesee-io/codesee-action) | action | digest | `7e12789` -> `7d6ca0f` | | [chromaui/action](https://togithub.com/chromaui/action) | action | digest | `44caff7` -> `aaf825f` | | [crowdin/github-action](https://togithub.com/crowdin/github-action) | action | minor | `v1.11.0` -> `v1.12.0` | --- ### Release Notes <details> <summary>crowdin/github-action (crowdin/github-action)</summary> ### [`v1.12.0`](https://togithub.com/crowdin/github-action/releases/tag/v1.12.0) [Compare Source](https://togithub.com/crowdin/github-action/compare/v1.11.0...v1.12.0) ##### What's Changed - feat: add support for team review requests by [@​fernandogelin](https://togithub.com/fernandogelin) in [crowdin/github-action#180 ```diff - name: Crowdin Action uses: crowdin/github-action@v1 with: upload_sources: true download_translations: true localization_branch_name: l10n_crowdin_translations create_pull_request: true pull_request_title: 'New Crowdin Translations' pull_request_body: 'New Crowdin translations by Crowdin GH Action' pull_request_base_branch_name: 'main' + pull_request_team_reviewers: 'crowdin-team-reviewer' env: GITHUB_TOKEN: ${{ secrets.GH_TOKEN }} CROWDIN_PROJECT_ID: ${{ secrets.CROWDIN_PROJECT_ID }} CROWDIN_PERSONAL_TOKEN: ${{ secrets.CROWDIN_PERSONAL_TOKEN }} ``` ##### New Contributors - [@​fernandogelin](https://togithub.com/fernandogelin) made their first contribution in [crowdin/github-action#180 **Full Changelog**: crowdin/github-action@v1...v1.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/weareinreach/InReach). PR-URL: #679 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new input argument
pull_request_team_reviewers. GitHub's API to request reviewers takes different arguments for users and teams, for example:With these changes, PRs opened by this action can now have requested reviews from users and/or teams. Both are optional.
Documentation has also been updated to include the new argument.