Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase memory in VM #16

Closed
straight-shoota opened this issue Jan 18, 2023 · 5 comments
Closed

Increase memory in VM #16

straight-shoota opened this issue Jan 18, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@straight-shoota
Copy link

Hi, I'm evaluating the use of this action for running CI for https://github.com/crystal-lang/crystal on FreeBSD. But the memory limit of 4GB restricts that (see https://github.com/crystal-lang/crystal/actions/runs/3943057224/jobs/6747446954).

I understand this is just an arbitrary limit. The runner has more to spare.

Would it be possible to make the memory setting configurable?

Perhaps it could also automatically delegate (almost) all memory available in the runner environment by default.
@jacob-carlborg
Copy link
Contributor

Would it be possible to make the memory setting configurable?

Yes, that should be doable.

@jacob-carlborg jacob-carlborg added the enhancement New feature or request label Jan 18, 2023
@straight-shoota
Copy link
Author

I suppose the same applies to cpuCount.

@jacob-carlborg
Copy link
Contributor

I suppose the same applies to cpuCount.

Please report a separate issue for that, so it's not forgotten.

@straight-shoota straight-shoota mentioned this issue Jan 19, 2023
Closed
jacob-carlborg added a commit that referenced this issue Feb 1, 2023
@jacob-carlborg
Fix #16: Increase memory in VM
dc2fd8c 
This adds support for configuring memory of the VM and also increases
the default memory.
jacob-carlborg added a commit that referenced this issue Feb 1, 2023
@jacob-carlborg
fixup! Fix #16: Increase memory in VM
9c0d447
jacob-carlborg added a commit that referenced this issue Feb 6, 2023
@jacob-carlborg
Fix #16: Increase memory in VM
22ba390 
This adds support for configuring memory of the VM and also increases
the default memory.
jacob-carlborg added a commit that referenced this issue Feb 7, 2023
@jacob-carlborg
Fix #16: Increase memory in VM
638446b 
This adds support for configuring memory of the VM and also increases
the default memory.
@straight-shoota
Copy link
Author

Thanks for implementing this 🙇
My workflow now succeeds with enough memory.

@jacob-carlborg
Copy link
Contributor

Awesome 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacob-carlborg @straight-shoota