Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README example to use displayName attribute #486

Merged
merged 1 commit into from Jan 26, 2023

Conversation

mattb18
Copy link
Contributor

@mattb18 mattb18 commented Jan 24, 2023

Great package, just went through the getting started docs and noticed an issue.

Looks like the assertion attributes returned from https://samltest.id have changed and cn is no longer included, meaning that the hello function does not return a name as expected.

Example JWT using the demo:

{
  "aud": "http://localhost:8000",
  "exp": 1674593145,
  "iat": 1674589545,
  "iss": "http://localhost:8000",
  "nbf": 1674589545,
  "sub": "AAdzZWNyZXQx7NxVYHJFFRw4UvKpGl1OryGBhvN55fPjUn0gxghj1hxVn7EMYUpfVlUxOqJtDaM71rCefli2ws2KUxlNkUUZ9t/vftoJKeM7PyrPHpMP8KUdr4VWD0LvkvRv1yaN1BuNu69jopqm",
  "attr": {
    "SessionIndex": [
      "_1aab96ca96e7326043c3709b75f9043c"
    ],
    "displayName": [
      "Rick Sanchez"
    ],
    "eduPersonEntitlement": [
      "urn:mace:dir:entitlement:common-lib-terms"
    ],
    "givenName": [
      "Rick"
    ],
    "mail": [
      "rsanchez@samltest.id"
    ],
    "role": [
      "manager@Samltest.id"
    ],
    "sn": [
      "Sanchez"
    ],
    "telephoneNumber": [
      "+1-555-555-5515"
    ],
    "uid": [
      "rick"
    ],
    "urn:oasis:names:tc:SAML:attribute:subject-id": [
      "rsanchez@samltest.id"
    ]
  },
  "saml-session": true
}

Great package, just went through the getting started docs and noticed an issue.

Looks like the assertion attributes returned from https://samltest.id have changed and **cn** is no longer included, meaning that the hello function does not return a name as expected.

Example JWT using the demo:

```
{
  "aud": "http://localhost:8000",
  "exp": 1674593145,
  "iat": 1674589545,
  "iss": "http://localhost:8000",
  "nbf": 1674589545,
  "sub": "AAdzZWNyZXQx7NxVYHJFFRw4UvKpGl1OryGBhvN55fPjUn0gxghj1hxVn7EMYUpfVlUxOqJtDaM71rCefli2ws2KUxlNkUUZ9t/vftoJKeM7PyrPHpMP8KUdr4VWD0LvkvRv1yaN1BuNu69jopqm",
  "attr": {
    "SessionIndex": [
      "_1aab96ca96e7326043c3709b75f9043c"
    ],
    "displayName": [
      "Rick Sanchez"
    ],
    "eduPersonEntitlement": [
      "urn:mace:dir:entitlement:common-lib-terms"
    ],
    "givenName": [
      "Rick"
    ],
    "mail": [
      "rsanchez@samltest.id"
    ],
    "role": [
      "manager@Samltest.id"
    ],
    "sn": [
      "Sanchez"
    ],
    "telephoneNumber": [
      "+1-555-555-5515"
    ],
    "uid": [
      "rick"
    ],
    "urn:oasis:names:tc:SAML:attribute:subject-id": [
      "rsanchez@samltest.id"
    ]
  },
  "saml-session": true
}
```
@crewjam crewjam merged commit 2aeb2ef into crewjam:main Jan 26, 2023
@crewjam
Copy link
Owner

crewjam commented Jan 26, 2023

Thanks!

mgyongyosi pushed a commit to grafana/saml that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants