New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update etreeutils.TransformExcC14n signature #478
Conversation
The invocation does not match the current function signature: ``` github.com/crewjam/saml@v0.4.10/schema.go:767:41: not enough arguments in call to etreeutils.TransformExcC14n | have (*etree.Element, string) | want (*etree.Element, string, bool) ```
LGTM but looks like CI failed. |
@crewjam , thank you for looking in to this. I’ll fix it. |
See also #437. |
Running into the error when bumping to
cc: #437 |
@crewjam , please re-run the test. I got a clean test with go1.17. |
Done. I also need to go dig for the setting that let's CI run automatically for you, but I'm on vacation right now and left the laptop behind. :) |
@crewjam, nothing wrong with a healthy dose of Github while on vacation 😄 |
@crewjam , need you to re-launch the test again. Did not tidy the go.sum before. |
wait for crewjam/saml#478 been merged.
wait for crewjam/saml#478 been merged.
@crewjam hate to bother you, but this PR seems been stale for a while. I am keen to see this PR getting merged. |
I think the most recent one has failed. Haven't had a chance to look further |
@crewjam , I am running with the |
@crewjam , updated to the latest github.com/russellhaering/goxmldsig with its dependencies. Please approve the workflow. |
Done. I did just fix the setting so this shouldn't keep needing approval. |
@crewjam , the test now pass. However, the linter throws an error:
|
I'll fix up the linter. Thanks! And sorry this was such a slog. :/ |
@crewjam , thank you for merging this 👍 if possible, please tag with new version. |
The invocation does not match the current function signature:
Resolves: #461