feat: Add Subject ID attribute support #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
hf
force-pushed
the
hf/add-subject-id-attribute
branch
from
77448f8
to
a4b7ee2
Compare
hf
force-pushed
the
hf/add-subject-id-attribute
branch
from
a4b7ee2
to
28f5bcf
Compare
|
Fixes #441 |
|
Hi @hf, we ran into this issue as well. Thanks for putting together this PR! In the meantime, we're using the workaround of having a custom AssertionMaker in our IdentityProvider that first calls DefaultAssertionMaker.MakeAssertion(), and then patches values we'd like to change before returning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the SAML V2.0 Subject Identifier Attributes Profile Version 1.0 which supersedes persistent
NameID.Additionally, adds support for passing in a different
NameIDFormat.