Use upstream compiler for linux/riscv64 and freebsd/riscv64 #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also addresses #165 |
|
Sorry for the delay, looking at this now. I am not a fan of removing support for linux/riscv, even in favor of linux/riscv64, other than that, LGTM, thanks for the PR! Merging your PR, but I'll push a commit to revert the linux/riscv removal. |
creack
added a commit
that referenced
this pull request
Oct 28, 2023
…the official riscv64 (see #168).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #149 mentions, riscv compiler for Golang had long been mainlined. Latest commit in the repo that
Dockerfile.riscvuses is from 2017.This PR removes separate riscv build environment in favor of using official Go toolchain.