Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory names are not fixed #936

Open
szepeviktor opened this issue Feb 14, 2024 · 2 comments
Open

Directory names are not fixed #936

szepeviktor opened this issue Feb 14, 2024 · 2 comments
Labels
enhancement Improve the expected

Comments

@szepeviktor
Copy link
Contributor

Please see https://github.com/wdes/mail-autodiscover-autoconfig/pull/10/commits

[typos 81bb75e] Rename dir
 5 files changed, 0 insertions(+), 0 deletions(-)
 rename src/{ressources => ressource}/AppleResponse.rs (100%)
 rename src/{ressources => ressource}/AutoDiscoverJson.rs (100%)
 rename src/{ressources => ressource}/AutoDiscoverXml.rs (100%)
 rename src/{ressources => ressource}/DnsTxtResponse.rs (100%)
 rename src/{ressources => ressource}/Version.rs (100%)
@szepeviktor
Copy link
Contributor Author

szepeviktor commented Feb 14, 2024

ressources => ressource

Bad fix! It was my typo :)

It should be ressources -> resources

@epage epage added the enhancement Improve the expected label Feb 15, 2024
@epage
Copy link
Collaborator

epage commented Feb 15, 2024

This was intentional but I'm not finding any notes documenting why it was done to help in deciding whether to re-evaluate this.

Correcting would be complicated. We'd have defer renaming of directories until everything else is processed and then make sure we rename the deepest directory first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve the expected
Projects
None yet
Development

No branches or pull requests

2 participants