Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4..4.10]: Matrix blocks not propagated when entry is translated/enabled into another website since #13181

Closed
yingban opened this issue May 10, 2023 · 12 comments
Assignees

Comments

@yingban
Copy link

yingban commented May 10, 2023

What happened?

Description

When a entry is enabled to another website, the matrix blocks are not propagated, even if the propagation method is set to 'Save blocks to other sites in the same site group".

Steps to reproduce

  1. Create a matrix field with different block types.
  2. Assign it to an entry
  3. Create blocks inside entry
  4. Enable entries into another website

Expected behavior

The matrix blocks should be copied and 1:1 between the two different versions.

Actual behavior

Matrix field is empty and the blocks are not propagated.

Craft CMS version

4.4.10.1

PHP version

8.1

@i-just
Copy link
Contributor

i-just commented May 11, 2023

Hi, thanks for raising a separate issue! I created a PR for this.

@weotch
Copy link
Contributor

weotch commented May 12, 2023

@i-just, I tried out your PR and it didn't fix the issue for me.

Here's a video showing how I experience this:

Screen.Recording.2023-05-11.at.6.24.13.PM.mov

One thing I've noticed is that setting the 'autosaveDrafts' => false, config option fixes this. Here's the same steps with that setting enabled:

Screen.Recording.2023-05-11.at.6.26.25.PM.mov

I also don't experience this when 'autosaveDrafts' => true if I save the entry after adding the new site super quickly, like before the autosave completes.

@i-just
Copy link
Contributor

i-just commented May 12, 2023

@weotch, is your “Blocks” field a matrix or a neo? What is that field’s propagation method set to?

@weotch
Copy link
Contributor

weotch commented May 12, 2023

It is Matrix (though we're using Spoon with it).

Propagation is set to "Save blocks to other sites with the same language"

@brandonkelly
Copy link
Member

This is fixed now for the next release. We should be getting a hotfix out later today, but if you want to test before then, you can change your craftcms/cms requirement in composer.json to dev-develop#c575444a6e7243e8fb7655c68b8ce44569c74f99 as 4.4.10.1 and run composer update.

@brandonkelly
Copy link
Member

Craft 4.4.11 is out now with the fix.

@yingban
Copy link
Author

yingban commented May 15, 2023

@brandonkelly thanks for fixing

@weotch
Copy link
Contributor

weotch commented May 23, 2023

4.4.11 did not fix my issue. @yingban did it work for you?

@yingban
Copy link
Author

yingban commented May 23, 2023

@weotch
it does work well with blocks which does not contains super table fields.
There were a PR in another thread about it, but did not have time to test it yet.

@brandonkelly
Copy link
Member

Yeah my Super Table PR (verbb/super-table#519) has been merged, but not released yet.

You should be able to test the fix ahead of release by changing your verbb/super-table constraint in composer.json to dev-craft-4, and running composer update.

@weotch
Copy link
Contributor

weotch commented May 23, 2023

Huh, even with the Super Table update, I'm still encountering that same issue. Here's the versions I'm running

image

@brandonkelly
Copy link
Member

@weotch Can you send a zip of your composer.json, composer.lock, and config/project/ directory over to support@craftcms.com, and point us to the section that is happening in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants